Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including .NET sample for raw message subscriber #4505

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

rochabr
Copy link
Contributor

@rochabr rochabr commented Jan 27, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

  • Including .NET sample for raw message subscriber using Dapr's pubsub
  • New link to .NET sample from the samples repo
  • Fixing attribute name for declarative subscription from rawPayload to isRawPayload

…ative subscription

Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
@marcduiker
Copy link
Contributor

Really good addition to the docs! I was confused with the Subscription schema though, since the docs don't mention this at all:
https://docs.dapr.io/reference/resource-specs/subscription-schema/
Can you add the metadata.isRawPayload field here as well?

msfussell and others added 2 commits February 4, 2025 11:54
…bsub/pubsub-raw.md

Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Mark Fussell <markfussell@gmail.com>
…bsub/pubsub-raw.md

Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Mark Fussell <markfussell@gmail.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

…message subscriptions

Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 46be695 into dapr:v1.14 Feb 6, 2025
7 checks passed
@rochabr rochabr deleted the pubsub-raw-message branch February 6, 2025 20:00
@rochabr
Copy link
Contributor Author

rochabr commented Feb 6, 2025

thanks @marcduiker @msfussell and @hhunter-ms !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants