-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Dapr Shared Docs #4121
Initial Dapr Shared Docs #4121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review - @msfussell please also take a look!
@salaboy - @msfussell suggested I update the diagrams and send you the slides in case you wanted to tweak. Here's the pptx link: |
Thanks a lot for doing this @hhunter-ms ! the diagrams look amazing |
@hhunter-ms there are a few things that I need to manually change.. but the rest looks good.. I will tackle these changes in the next few days. |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salaboy - Here are my comments. Let's get this in this week.
Stale PR, paging all reviewers |
@salaboy - Tell me when you have time to review these comments to that we can get the PR merged. Suggest getting changes to the Dapr-Shared repo at the same time |
Stale PR, paging all reviewers |
bump.. working on this now |
Ok, quick update here. Once these changes are done, I am submitting a PR to the Finally, I will align this PR to link to that tutorial and maybe use the diagrams shown there. |
628aafb
to
dd5552a
Compare
…apr-shared.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr-shared.md Signed-off-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
* doc: http metrics path normalization Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * doc: code review & path matching rename Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * doc: add configuration examples Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * update: update docs based on last proposal changes Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: more updates based on the ingress/egress merge Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * doc: code review comments Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * doc: code review comments Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: add excludeVerbs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: new line Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: add review meeting changes Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: apply hunter suggestions Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Done
- Blog: http://salaboy.com <http://salaboy.wordpress.com>
- Github user: http://github.com/salaboy
- Twitter: http://twitter.com/salaboy
- Mauricio "Salaboy" Salatino -
…On Thu, 27 Jun 2024 at 16:55, Hannah Hunter ***@***.***> wrote:
***@***.**** commented on this pull request.
@salaboy <https://github.com/salaboy> - could you "Ignore all" the
spelling error in the daemonset.png diagram to remove the red squiggly
lines? other than that, lgtm!
—
Reply to this email directly, view it on GitHub
<#4121 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACCMXVCF4WMEAFQN7OYJG3ZJQYX3AVCNFSM6AAAAABG6LU66CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBVHAZTKNRZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: salaboy <Salaboy@gmail.com>
@holopin-bot @salaboy Thanks Salaboy! |
Congratulations @salaboy, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8o9wf164060clcsdjvmvli This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This is an initial version of the Dapr Shared docs. Now that Dapr Shared is out of Sandbox, a new set of docs are needed for new users to understand how to use it and get started with Dapr Shared. I would appreciate feedback on the location of these docs and what other sections to include.
Issue reference