Skip to content

Commit

Permalink
Use Google Analytics 4 ID for v1.6 via head-end hook (#2963)
Browse files Browse the repository at this point in the history
* Use Google Analytics 4 ID for v1.6

Signed-off-by: Patrice Chalin <chalin@cncf.io>

* Add GA4 ID via head-end

Signed-off-by: Patrice Chalin <chalin@cncf.io>

* Fix PR template link

Signed-off-by: Patrice Chalin <chalin@cncf.io>

* validate-links: ontinue-on-error

Signed-off-by: Patrice Chalin <chalin@cncf.io>

Signed-off-by: Patrice Chalin <chalin@cncf.io>
  • Loading branch information
chalin authored Nov 30, 2022
1 parent e18b8c6 commit 9231f27
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Thank you for helping make the Dapr documentation better!

**Please follow this checklist before submitting:**
- [ ] Commits are signed with Developer Certificate of Origin (DCO - [learn more](https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work))
- [ ] [Read the contribution guide](https://docs.dapr.io/contributing/contributing-docs/)
- [ ] [Read the contribution guide](https://docs.dapr.io/contributing/docs-contrib/contributing-docs/)
- [ ] Commands include options for Linux, MacOS, and Windows within codetabs
- [ ] New file and folder names are globally unique
- [ ] Page references use shortcodes instead of markdown or URL links
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/link_validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
validate:
runs-on: ubuntu-latest
env:
env:
PYTHON_VER: 3.7
steps:
- uses: actions/checkout@v2
Expand All @@ -35,6 +35,6 @@ jobs:
python3 -m pip install --upgrade pip
pip3 install setuptools wheel twine tox mechanical-markdown
- name: Check Markdown Files
continue-on-error: true
run: |
for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done
for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name ;done
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The following branches are currently maintained:
| [v1.7](https://github.com/dapr/docs) (primary) | https://docs.dapr.io | Latest Dapr release documentation. Typo fixes, clarifications, and most documentation goes here. |
| [v1.8](https://github.com/dapr/docs/tree/v1.8) (pre-release) | https://v1-8.docs.dapr.io/ | Pre-release documentation. Doc updates that are only applicable to v1.8+ go here. |

For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/contributing-docs/#branch-guidance) document.
For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/docs-contrib/contributing-docs/#branch-guidance) document.

## Contribution guidelines

Expand Down
2 changes: 1 addition & 1 deletion daprdocs/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ disableKinds = ["taxonomy", "term"]

# Google Analytics
[services.googleAnalytics]
id = "UA-149338238-3"
id = "UA-00000000-0"

# Mounts
[module]
Expand Down
13 changes: 11 additions & 2 deletions daprdocs/layouts/partials/hooks/head-end.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
{{ with .Site.Params.algolia_docsearch }}
{{ with .Site.Params.algolia_docsearch -}}
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />
{{ end }}
{{ end -}}

<script async src="https://www.googletagmanager.com/gtag/js?id=G-60C6Q1ETC1"></script>
<script>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());

gtag('config', 'G-60C6Q1ETC1');
</script>

0 comments on commit 9231f27

Please sign in to comment.