Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated flags in List operation #1478

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jan 22, 2025

The CLI currently uses a deprecated flag in daprd for max request size and read buffer body. This PR sets the correct flags. The CLI can continue to exist with the user facing --dapr prefix.

Signed-off-by: yaron2 <schneider.yaron@live.com>
@yaron2 yaron2 requested review from a team as code owners January 22, 2025 00:45
Copy link

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches supported migration.
LGTM. Thank you for this, because it makes our tests work.

@yaron2 yaron2 merged commit 953c4a2 into dapr:release-1.15 Jan 22, 2025
26 of 27 checks passed
@yaron2 yaron2 deleted the flags-1 branch January 22, 2025 06:52
@yaron2
Copy link
Member Author

yaron2 commented Jan 22, 2025

@mikeee feel free to release rc.2

paulyuk added a commit to dapr/quickstarts that referenced this pull request Jan 22, 2025
Need RC.2 containing fix for deprecation flags.  see dapr/cli#1478

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants