fix: scheduler host address passed to runtime #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
mikeee
force-pushed
the
fix-scheduler-run
branch
from
316868e to
107561e
Compare
if the scheduler container is not active, the scheduler flag will not be passed to the runtime Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
yaron2
approved these changes
Jul 10, 2024
|
@holopin-bot @mikeee Thanks Mike! |
|
Congratulations @mikeee, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8facc184500cjrqyu5rpwc This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the way
scheduler-host-addressis handled and adds the arg to enable standalone mode runs.The scheduler can now be initialised by flag with the run command, if an older runtime is installed there is some janky logic to not pass the flag. Instead, a notice is displayed.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1420
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: