-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slombard/web 171 implement https #390
base: main
Are you sure you want to change the base?
Conversation
Does not compile according to git actions |
It's a super rough Draft, sorry for not making it more clear. I opened it only to share the extended version of Debug::log. |
…ak .yml file to install openssl in the ubuntu container running the tests
Now it's solved. |
I mean. It compiles. Https is not implemented yet. The problem was that openssl needs to be installed as dependencies into the container of Github Actions. |
…nd add logic to acceptNewConnection to create a ssl struct for the connection and pass it to the Connection object on initialisation
Another couple of hours for another small step forward. More tomorrow. Not so far from the end. |
I'll open this only for visibility. It has a batter version of the Debug::log function that takes also color as (optional) option. @dantol29
Sure! Here's a comprehensive list of what we have done so far and what remains to be done for implementing HTTPS support in your HTTP server, presented in a checklist format.
SSL Integration Checklist
SSLManager and SSLContext: Implemented singleton
SSLManager
andSSLContext
classes for managing SSL/TLS initialization and context.SSLManager
.SSLContext
.Accepting SSL Connections: Modified the
acceptNewConnection
method to handle SSL connections.Connection
object.Read Data from SSL Connections: Implement SSL-enabled reading in the
readSocket
method of theConnection
class.SSL_read
instead ofrecv
.Write Data to SSL Connections: Implement SSL-enabled writing in the
writeSocket
method of theConnection
class.SSL_write
instead ofsend
.Cleanup SSL Resources: Ensure proper cleanup of SSL resources when a connection is closed.
SSL_shutdown
andSSL_free
are called in thecloseClientConnection
method.Configuration: Ensure the server is correctly configured to differentiate between HTTP and HTTPS connections.
SSL_PORT
and ensure it's used consistently.