Dtimofte/qodana fixes (#18)

* qodana fixes

* fetch full git history

* replace if with conditional operator

* change var to val

---------

Co-authored-by: Dan Timofte <dantimofte@proton.me>

.github/workflows/build.yml

@@ -138,6 +138,9 @@ jobs:
       # Check out the current repository
       - name: Fetch Sources
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}  # to check out the actual pull request commit, not the merge commit
+          fetch-depth: 0  # a full history is required for pull request analysis
 
       # Set up Java environment for the next steps
       - name: Setup Java
@@ -149,6 +152,8 @@ jobs:
       # Run Qodana inspections
       - name: Qodana - Code Inspection
         uses: JetBrains/qodana-action@v2024.2.3
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} # read the steps about it below
         with:
           cache-default-branch-only: true
 

qodana.yml

@@ -2,7 +2,7 @@
 # https://www.jetbrains.com/help/qodana/qodana-yaml.html
 
 version: 1.0
-linter: jetbrains/qodana-jvm-community:latest
+linter: jetbrains/qodana-jvm-community:2024.2
 projectJDK: "17"
 profile:
   name: qodana.recommended

src/main/java/ac/quant/quickfixspec/clickableviews/QuickFixPsiReferenceProvider.java

@@ -3,9 +3,7 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiReference;
 import com.intellij.psi.PsiReferenceProvider;
-import com.intellij.psi.xml.XmlAttribute;
 import com.intellij.psi.xml.XmlAttributeValue;
-import com.intellij.psi.xml.XmlTag;
 import com.intellij.util.ProcessingContext;
 import lombok.extern.slf4j.Slf4j;
 import org.jetbrains.annotations.NotNull;

src/main/java/ac/quant/quickfixspec/clickableviews/QuickfixPsiReference.java

@@ -1,11 +1,8 @@
 package ac.quant.quickfixspec.clickableviews;
 
-import com.intellij.openapi.project.Project;
-import com.intellij.openapi.util.NlsSafe;
 import com.intellij.openapi.util.TextRange;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiReference;
-import com.intellij.psi.xml.XmlAttribute;
 import com.intellij.psi.xml.XmlAttributeValue;
 import com.intellij.psi.xml.XmlTag;
 import com.intellij.util.IncorrectOperationException;

src/main/java/ac/quant/quickfixspec/clickableviews/QuickfixSpecPsiReferenceContributor.java

@@ -5,9 +5,7 @@
 import com.intellij.psi.PsiReferenceContributor;
 import com.intellij.psi.PsiReferenceRegistrar;
 import com.intellij.patterns.PsiElementPattern;
-import com.intellij.psi.xml.XmlAttribute;
 import com.intellij.psi.xml.XmlAttributeValue;
-import com.intellij.psi.xml.XmlTag;
 import org.jetbrains.annotations.NotNull;
 import lombok.extern.slf4j.Slf4j;
 

src/main/java/ac/quant/quickfixspec/inlay/QuickfixInlayHintsProvider.java

@@ -2,24 +2,15 @@
 
 import com.intellij.codeInsight.hints.*;
 import com.intellij.codeInsight.hints.presentation.*;
-import com.intellij.ide.DataManager;
 import com.intellij.lang.Language;
 import com.intellij.lang.xml.XMLLanguage;
-import com.intellij.openapi.actionSystem.ActionManager;
-import com.intellij.openapi.actionSystem.ActionPlaces;
-import com.intellij.openapi.actionSystem.AnActionEvent;
-import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.editor.Editor;
-import com.intellij.openapi.editor.Inlay;
 import com.intellij.psi.*;
 import com.intellij.psi.xml.*;
 import lombok.extern.slf4j.Slf4j;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import javax.swing.*;
-import java.awt.*;
-import java.awt.event.MouseAdapter;
-import java.awt.event.MouseEvent;
 
 import static ac.quant.quickfixspec.common.PsiUtils.getRootTag;
 

src/main/java/ac/quant/quickfixspec/toolbar/QuickfixFloatingToolbar.java

@@ -1,6 +1,5 @@
 package ac.quant.quickfixspec.toolbar;
 import com.intellij.openapi.Disposable;
-import com.intellij.openapi.actionSystem.ActionGroup;
 import com.intellij.openapi.actionSystem.DataContext;
 import com.intellij.openapi.actionSystem.PlatformDataKeys;
 import com.intellij.openapi.editor.toolbar.floating.*;

src/main/kotlin/ac/quant/quickfixspec/documentation/QuickfixComponentDocumentationTarget.kt

@@ -7,7 +7,6 @@ import com.intellij.platform.backend.documentation.DocumentationResult
 import com.intellij.platform.backend.documentation.DocumentationTarget
 import com.intellij.platform.backend.presentation.TargetPresentation
 import com.intellij.psi.xml.XmlTag
-import com.intellij.openapi.diagnostic.Logger
 
 @Suppress("UnstableApiUsage")
 class QuickfixComponentDocumentationTarget(
@@ -36,11 +35,7 @@ class QuickfixComponentDocumentationTarget(
 
     private fun getComponentDetails(componentName: String): String {
         val component: XmlTag? = findComponent(rootTag, componentName)
-        if (component == null) {
-            println("Component with name $componentName not found")
-            return ""
-        }
-
+        component ?: return ""
         return getDisplayText(component)
     }
 

src/main/kotlin/ac/quant/quickfixspec/documentation/QuickfixComponentDocumentationTargetProvider.kt

@@ -1,7 +1,5 @@
 package ac.quant.quickfixspec.documentation
 
-//class QuickfixComponentDocumentationTargetProvider : DocumentationTargetProvider {
-
 import ac.quant.quickfixspec.common.PsiUtils.getRootTag
 import com.intellij.platform.backend.documentation.DocumentationTarget
 import com.intellij.platform.backend.documentation.DocumentationTargetProvider

src/main/kotlin/ac/quant/quickfixspec/ui/ShowNotificationSampleAction.kt

@@ -3,7 +3,6 @@ package ac.quant.quickfixspec.ui
 import com.intellij.notification.*
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
-import com.intellij.openapi.actionSystem.CommonDataKeys
 
 
 class ShowNotificationSampleAction : AnAction() {