Tidy up from review

src/WebUI/Common/Services/SydneyTimeProvider.cs

@@ -0,0 +1,10 @@
+namespace WebUI.Common.Services;
+
+public class SydneyTimeProvider : TimeProvider
+{
+    private const string Timezone = "AUS Eastern Standard Time";
+
+    private readonly TimeZoneInfo _sydneyTimeZone = TimeZoneInfo.FindSystemTimeZoneById(Timezone);
+
+    public override TimeZoneInfo LocalTimeZone => _sydneyTimeZone;
+}

src/WebUI/Common/Services/DateTimeService.cs → src/WebUI/Common/Services/TimeProviderExt.cs

@@ -1,17 +1,5 @@
 namespace WebUI.Common.Services;
 
-// Problem: Issue is that DateTime.Now could be different depending on where the code is running
-// Solution: Force 'now' to be based on AEST, then converted to UTC
-
-public class SydneyTimeProvider : TimeProvider
-{
-    private const string Timezone = "AUS Eastern Standard Time";
-
-    private readonly TimeZoneInfo _sydneyTimeZone = TimeZoneInfo.FindSystemTimeZoneById(Timezone);
-
-    public override TimeZoneInfo LocalTimeZone => _sydneyTimeZone;
-}
-
 public static class TimeProviderExt
 {
     public static DateOnly GetToday(this TimeProvider timeProvider)
@@ -45,4 +33,4 @@ public static DateTime GetEndOfDayUtc(this TimeProvider timeProvider, DateOnly d
 
         return endOfDayUtc;
     }
-}
+}

src/WebUI/Features/DailyScrum/Queries/GetDailyScrumQuery.cs

@@ -5,9 +5,6 @@
 
 namespace WebUI.Features.DailyScrum.Queries;
 
-// TODO: Timezones are still not matching up. locally UTC times are working (i.e. in the middle of the day),
-// But on docker they are from midnight to midnight (which is not correct)
-
 public record GetDailyScrumQuery(string Name, int? ClientDays, DateOnly? LastWorkingDay)
     : IRequest<DailyScrumViewModel>;
 

tests/UnitTests/SydneyTimeProviderTests.cs

@@ -0,0 +1,16 @@
+using FluentAssertions;
+using WebUI.Common.Services;
+
+namespace UnitTests;
+
+public class SydneyTimeProviderTests
+{
+    [Fact]
+    public void GetLocalNow_ReturnsSydneyTime()
+    {
+        var sut = new SydneyTimeProvider();
+        var localNow = DateTimeOffset.Now;
+        var result = sut.GetLocalNow();
+        result.Should().BeCloseTo(localNow, precision: TimeSpan.FromSeconds(5));
+    }
+}

tests/UnitTests/UnitTest1.cs → tests/UnitTests/TimeProviderExtTests.cs

@@ -3,18 +3,6 @@
 
 namespace UnitTests;
 
-public class SydneyTimeProviderTests
-{
-    [Fact]
-    public void GetLocalNow_ReturnsSydneyTime()
-    {
-        var sut = new SydneyTimeProvider();
-        var localNow = DateTimeOffset.Now;
-        var result = sut.GetLocalNow();
-        result.Should().BeCloseTo(localNow, precision: TimeSpan.FromSeconds(5));
-    }
-}
-
 public class TimeProviderExtTests
 {
     [Fact]
@@ -46,4 +34,4 @@ public void GetEndOfDayUtc_GivenSydneyTimeZone_ReturnsCorrectUtc()
 
 
 
-}
+}