Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve back button on course layout #50

Open
danieljancar opened this issue Feb 21, 2024 · 0 comments
Open

Improve back button on course layout #50

danieljancar opened this issue Feb 21, 2024 · 0 comments
Labels
area: course Issue regarding the main package enhancement New feature or request

Comments

@danieljancar
Copy link
Owner

danieljancar commented Feb 21, 2024 •
edited
Loading

Description

As a user I want to go to the last page I visited, before I entered the course, when I press the back button on c/:courseId or it's children, instead of going to the / page.

  • Package: course

Expected Behavior

I want to navigate back to my last route with browser history.back() utility which isn't a course page but would be c/ or / where I can see the courses. Pretty much just leave the course detail page, no matter how far I've navigated in the c/:courseId, to the route before I entered course detail at c/:courseId.

Actual Behavior

I'm navigating to root route at /

Possible Fix

Use native function https://developer.mozilla.org/en-US/docs/Web/API/History/back

Steps to Reproduce

  1. Navigate to a course at c/:courseId
  2. Press the back arrow button
@danieljancar danieljancar added bug Something isn't working good first issue Good for newcomers labels Feb 21, 2024
@danieljancar danieljancar added this to the As a user I want to be able to navigate to the most important sites with navbars, footers, etc. milestone Feb 21, 2024
@danieljancar danieljancar moved this to Backlog in chorizo/kanban Feb 21, 2024
@danieljancar danieljancar added the area: course Issue regarding the main package label Feb 23, 2024
@valeriaxxx valeriaxxx self-assigned this Mar 4, 2024
@valeriaxxx valeriaxxx moved this from Backlog to In progress in chorizo/kanban Mar 4, 2024
@valeriaxxx valeriaxxx linked a pull request Mar 4, 2024 that will close this issue
Updated Course Navbar #64
Closed
7 tasks
@valeriaxxx valeriaxxx moved this from In progress to Ready in chorizo/kanban Mar 4, 2024
@valeriaxxx valeriaxxx assigned valeriaxxx and unassigned valeriaxxx Mar 4, 2024
@valeriaxxx valeriaxxx moved this from Ready to In progress in chorizo/kanban Mar 4, 2024
@valeriaxxx valeriaxxx linked a pull request Mar 4, 2024 that will close this issue
50 improve back button on course layout #65
Closed
7 tasks
This was unlinked from pull requests Mar 4, 2024
Updated Course Navbar #64
Closed
50 improve back button on course layout #65
Closed
@valeriaxxx valeriaxxx linked a pull request Mar 4, 2024 that will close this issue
Different types of changes #66
Closed
7 tasks
@valeriaxxx valeriaxxx moved this from In progress to Needs review in chorizo/kanban Mar 4, 2024
@danieljancar danieljancar added enhancement New feature or request and removed bug Something isn't working labels Mar 5, 2024
@danieljancar danieljancar moved this from Needs review to In progress in chorizo/kanban Mar 5, 2024
@danieljancar danieljancar removed this from the As a user I want to be able to navigate to the most important sites with navbars, footers, etc. milestone Mar 6, 2024
@valeriaxxx valeriaxxx removed a link to a pull request Mar 6, 2024
Different types of changes #66
Closed
7 tasks
@valeriaxxx valeriaxxx linked a pull request Mar 7, 2024 that will close this issue
Improve back button on course layout #74
Closed
7 tasks
@valeriaxxx valeriaxxx moved this from In progress to Needs review in chorizo/kanban Mar 7, 2024
@danieljancar danieljancar moved this from Needs review to In progress in chorizo/kanban Mar 7, 2024
@danieljancar danieljancar moved this from In progress to Ready in chorizo/kanban Mar 14, 2024
@danieljancar danieljancar removed the good first issue Good for newcomers label Mar 14, 2024
@danieljancar danieljancar moved this from Ready to Backlog in chorizo/kanban Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: course Issue regarding the main package enhancement New feature or request
Projects
chorizo/kanban
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve back button on course layout danieljancar/chorizo
3 participants
@KunzRobert @danieljancar @valeriaxxx