Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #33

Open
kupiakos opened this issue Nov 20, 2023 · 1 comment
Open

Add CI #33

kupiakos opened this issue Nov 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kupiakos
Copy link
Collaborator

Ensure that at the very least:

  • cargo test works
  • cargo +nightly test --all-features works

It could also:

  • Check the MSRV
  • Check formatting
  • Check clippy
@danielhenrymantilla danielhenrymantilla added the bug Something isn't working label Dec 6, 2023
@danielhenrymantilla
Copy link
Owner

Yes, this is so key; I guess back in the day I got lazy and was just cargo testing myself 😱.

This should be top-priority before anything else (at least the testing part; the extra features such as checking formatting would have to be embedded within their own "format properly the codebase" efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants