Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shell scripts to tools/ #68

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Move shell scripts to tools/ #68

merged 2 commits into from
Jan 22, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 19, 2024

The script is not part of the dandisets-healthstatus package and thus does not belong in code/.

@jwodder jwodder added the code quality Nonfunctional improvements to the codebase label Jan 19, 2024
@jwodder jwodder requested a review from yarikoptic January 19, 2024 13:21
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f362c2f) 61.58% compared to head (b7aa6c0) 61.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   61.58%   61.58%           
=======================================
  Files           9        9           
  Lines         669      669           
  Branches      164      164           
=======================================
  Hits          412      412           
  Misses        238      238           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

Agree -- better not in code/. Let's move under tools/ or alike then -- better not to trash the top level.

@jwodder
Copy link
Member Author

jwodder commented Jan 19, 2024

@yarikoptic Should run.sh and run_loop.sh also be moved to tools/?

@yarikoptic
Copy link
Member

I think so since they are just to help running this one but they might need tune ups to remain working

@jwodder jwodder changed the title Move checknwb.sh to top level of repository Move shell scripts to tools/ Jan 19, 2024
@jwodder
Copy link
Member Author

jwodder commented Jan 22, 2024

@yarikoptic Should this be merged now?

@yarikoptic yarikoptic merged commit e6bc164 into main Jan 22, 2024
16 checks passed
@yarikoptic yarikoptic deleted the mv-checknwb branch January 22, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants