Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for pynwb v3 which has changed API slightly #1584

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 3, 2025

Closes #1582.

@jwodder jwodder added the patch Increment the patch version when merged label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (e87941e) to head (4439a1d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
dandi/pynwb_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   88.59%   88.66%   +0.06%     
==========================================
  Files          78       78              
  Lines       10855    10857       +2     
==========================================
+ Hits         9617     9626       +9     
+ Misses       1238     1231       -7     
Flag Coverage Δ
unittests 88.66% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as ready for review March 3, 2025 13:47
@jwodder jwodder requested a review from yarikoptic March 3, 2025 13:47
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Mar 3, 2025
@yarikoptic
Copy link
Member

Thank you @jwodder , let's proceed with release to get it addressed for the users.

@yarikoptic yarikoptic changed the title Support pynwb v3 Fix support pynwb v3 which changed API slightly Mar 3, 2025
@yarikoptic yarikoptic changed the title Fix support pynwb v3 which changed API slightly Fix support for pynwb v3 which has changed API slightly Mar 3, 2025
@yarikoptic yarikoptic merged commit 633e141 into master Mar 3, 2025
30 of 31 checks passed
@yarikoptic yarikoptic deleted the gh-1582 branch March 3, 2025 14:17
Copy link

github-actions bot commented Mar 3, 2025

🚀 PR was released in 0.67.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation errors out with pynwb 3.0.0
2 participants