New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hugo refactor #89

Merged

kabilar merged 30 commits into dandi:master from catalystneuro:hugo-refact

Feb 7, 2025

Contributor

luiztauffer commented Jan 16, 2025 •

edited

Loading

Change to Hugo framework, the current website content remains the same.

Fix #80

live demo: https://catalystneuro.github.io/dandi-hugo-example/

luiztauffer added 5 commits

January 16, 2025 12:52


          hugo

ce1b3b8


          remove

2c7e8ea


          Remove node_modules and other generated files from git tracking

c72eb41


          fix urls

9a6c8c3


          action

a636c01

Contributor Author

luiztauffer commented Jan 16, 2025

@kabilar could you take a look at this and let me know what you think?

asmacdo reviewed

View reviewed changes

hugo.yaml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

data/news.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

data/news.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

hugo.yaml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

docsy.work.sum Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

.github/workflows/deploy-github-pages.yml Outdated Show resolved Hide resolved

kabilar reviewed

View reviewed changes

Member

kabilar left a comment

Thanks @luiztauffer. The site looks great. I have added some minor comments here and will finishing reviewing this week.

luiztauffer and others added 9 commits

January 20, 2025 09:33


          Update hugo.yaml

b49dc6d

Co-authored-by: Austin Macdonald <austin@dartmouth.edu>


          Update data/news.yml

47e073b

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update data/news.yml

0bcc6c7

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update hugo.yaml

c3c322c

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update .github/workflows/deploy-github-pages.yml

95a70c5

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update .github/workflows/deploy-github-pages.yml

a82d46f

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update .github/workflows/deploy-github-pages.yml

6ee51f0

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update .github/workflows/deploy-github-pages.yml

dfe46d6

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update .github/workflows/deploy-github-pages.yml

1b0743a

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>

bendichter and others added 10 commits

January 31, 2025 11:53


          Update layouts/404.html

066b48e

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update content/en/_index.md

2772b7a

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update content/en/blog/_index.md

ac11291

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update content/en/_index.md

5c441a2

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update README.md

e29af4a

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update hugo.yaml

1b7a247

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update README.md

a187b1a

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update README.md

281d7f6

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update README.md

e3a130c

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>


          Update content/en/blog/2024-11-10-unraveling/index.md

188030d

Co-authored-by: Kabilar Gunalan <kabilar.gunalan@gmail.com>

Contributor Author

luiztauffer commented Feb 4, 2025

thank you for your review @kabilar , I submitted the changes you suggested, just kept the comments on the configuration file since these can be quite useful.
This is a major refactor, so my suggestion is that we focus here on general functionality and later go patching smaller things as necessary. Do you have admin access to the repo and could help configuring the github pages deployment?

luiztauffer requested review from kabilar and bendichter

February 4, 2025 08:20

luiztauffer added 2 commits

February 4, 2025 09:21


          remove md file

e3d1f34


          Merge branch 'hugo-refact' of https://github.com/catalystneuro/dandi.…

93aa54f

…github.io into hugo-refact

Member

kabilar commented Feb 4, 2025

Thanks @luiztauffer. Looks good. There are just a few unresolved comments above. Yes, I can configure the github pages deployment.

Member

kabilar commented Feb 4, 2025

Search results do not return team members:

And do you know why the search is not robust?

Member

kabilar commented Feb 7, 2025

After discussion with Luiz on Slack, will file issues for unresolved suggestions and proceed with merging.

This was referenced Feb 7, 2025

Create a DANDI alumni section #37

Closed

Add Google Analytics tag #90

Closed

Search results do not return team members #93

Open

Member

kabilar commented Feb 7, 2025

Search results do not return team members:

Filed #93

This was referenced Feb 7, 2025

Fix Ben's CV link #94

Closed

Delete netlify.toml file? #95

Closed

Delete package.json? #96

Closed

kabilar approved these changes

View reviewed changes

Member

kabilar left a comment

Thanks @luiztauffer. Great work.

kabilar merged commit be4cd14 into dandi:master

1 check passed

Member

kabilar commented Feb 7, 2025

Site is not rendering correctly even though the GitHub Actions run successfully. I am looking into it.

Member

kabilar commented Feb 7, 2025

Fixed the issue in #98. Site is now up.

kabilar mentioned this pull request

Social card #106

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet