Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Imperial units doesn't seem to change anything #61

Closed
reedy opened this issue Oct 24, 2024 · 2 comments · Fixed by #65
Closed

Changing Imperial units doesn't seem to change anything #61

reedy opened this issue Oct 24, 2024 · 2 comments · Fixed by #65
Assignees
Labels
bug Something isn't working

Comments

@reedy
Copy link
Contributor

reedy commented Oct 24, 2024

What happened?
Add a car, don't select imperial units initially

To Reproduce
Re-configure car to use imperial units after initially setting to not use imperial units

Expected behavior

Either by default after changing to imperial, or at least after a reload (fairly common thing to have to do in HA)/refresh of data, the units should change from KM to miles.

Deleting and re-adding with imperial selected (#60 to make it more obvious to others too!) did set the car up again with imperial units...

Log Output

Home Assistant Version
2024.10.3

Integration Version
v0.5.6

Additional context

@reedy reedy added the bug Something isn't working label Oct 24, 2024
@reedy
Copy link
Contributor Author

reedy commented Oct 24, 2024

Screenshot 2024-10-24 at 01 19 12

Though it does seem to have confused some of the graphs a bit..

@dan-r
Copy link
Owner

dan-r commented Oct 24, 2024

So the native unit of all measurements is metric, as this is what the Nissan API returns. By default, Home Assistant will convert the units and show in the unit for your locale/configuration.

The only reason this box exists is for countries like (maybe only) the UK who mostly use metric, except for a few exceptions like miles. As a result the only thing it changes is that is suggests to Home Assistant to use different units.

Because of this behaviour I may just remove the checkbox from the configure screen, but keep it on the initial setup screen. Even without this box you can click into each entity and change it manually and it'll convert everything for you.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants