Fix AdPods parsing behavior with resolveAll to false #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarissedmn
reviewed
Jan 27, 2025
spec/vast_client.spec.js
Outdated
| @@ -161,7 +158,7 @@ describe('VASTClient', () => { | |||
| expect(res.ads).toHaveLength(3); | |||
| }); | |||
|
|
|||
| it('resolves only next ad if requested', async () => { | |||
| fit('resolves only next ad if requested', async () => { | |||
There was a problem hiding this comment.
Perhaps we can create a ticket to add an ESLint rule to prevent fit from being pushed to production?
Suggested change
| fit('resolves only next ad if requested', async () => { | |
| it('resolves only next ad if requested', async () => { |
|
After removing |
clarissedmn
approved these changes
Feb 13, 2025
clementFrancon
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when a VAST contained an adPod with standalone ads, if a standalone ad appeared first in the VAST order, it would be parsed first, causing the adPod to not be resolved. As a result, the Player couldn't be aware that the VAST contained an adPod. According to IAB specifications, the adPod should take priority and play before any standalone ads. This PR addresses the issue by ensuring that the adPod is resolved first, followed by the standalone ads, when
getNextAdsis called.Issue
#360
Type