Made 2 methods private

dabrze · Jan 5, 2024 · 30e5e4b · 30e5e4b
1 parent 05b0057
commit 30e5e4b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 30 deletions.
diff --git a/docs/source/api.rst b/docs/source/api.rst
@@ -37,10 +37,6 @@ API
 
 .. autofunction:: src.WMSDTransformer.TOPSISAggregationFunction.improvement_genetic
 
-.. autofunction:: src.WMSDTransformer.TOPSISAggregationFunction.solve_quadratic_equation
-
-.. autofunction:: src.WMSDTransformer.TOPSISAggregationFunction.choose_appropriate_solution
-
 .. autoclass:: src.WMSDTransformer.PostFactumTopsisPymoo
 
 .. autoclass:: src.WMSDTransformer.ATOPSIS

diff --git a/src/WMSDTransformer.py b/src/WMSDTransformer.py
@@ -1283,16 +1283,8 @@ def improvement_genetic(
             return None
 
     @staticmethod
-    def solve_quadratic_equation(a, b, c):
-        """TO DO
-        Parameters
-        ----------
-        parameter : type
-            description
-        Returns
-        -------
-        TO DO
-        """
+    def __solve_quadratic_equation(a, b, c):
+
         discriminant = b**2 - 4 * a * c
         if discriminant < 0:
             return None
@@ -1301,18 +1293,10 @@ def solve_quadratic_equation(a, b, c):
         return solution_1, solution_2
 
     @staticmethod
-    def choose_appropriate_solution(
+    def __choose_appropriate_solution(
         solution_1, solution_2, lower_bound, upper_bound, objective
     ):
-        """TO DO
-        Parameters
-        ----------
-        parameter : type
-            description
-        Returns
-        -------
-        TO DO
-        """
+
         solution_1_is_feasible = upper_bound > solution_1 > lower_bound
         solution_2_is_feasible = upper_bound > solution_2 > lower_bound
         if solution_1_is_feasible:
@@ -1475,7 +1459,7 @@ def improvement_single_feature(
             - target_agg_value**2
         )
 
-        solutions = TOPSISAggregationFunction.solve_quadratic_equation(
+        solutions = TOPSISAggregationFunction.__solve_quadratic_equation(
             a, b, c
         )  # solutions are new performances in VS, not modifications
         if solutions is None:
@@ -1487,7 +1471,7 @@ def improvement_single_feature(
             solution_2 = ((solutions[1] / weights[j]) * criterion_range) + lower_bound
 
             # solution -- new performances in CS
-            solution = TOPSISAggregationFunction.choose_appropriate_solution(
+            solution = TOPSISAggregationFunction.__choose_appropriate_solution(
                 solution_1, solution_2, lower_bound, upper_bound, objective
             )
             if solution is None:
@@ -1645,7 +1629,7 @@ def improvement_single_feature(
             - target_agg_value**2
         )
 
-        solutions = TOPSISAggregationFunction.solve_quadratic_equation(
+        solutions = TOPSISAggregationFunction.__solve_quadratic_equation(
             a, b, c
         )  # solutions are new performances in VS, not modifications
         if solutions is None:
@@ -1657,7 +1641,7 @@ def improvement_single_feature(
             solution_2 = ((solutions[1] / weights[j]) * criterion_range) + lower_bound
 
             # solution -- new performances in CS
-            solution = TOPSISAggregationFunction.choose_appropriate_solution(
+            solution = TOPSISAggregationFunction.__choose_appropriate_solution(
                 solution_1, solution_2, lower_bound, upper_bound, objective
             )
             if solution is None:
@@ -1822,7 +1806,7 @@ def improvement_single_feature(
         )
         c = (v_ij[j] - NIS[j]) ** 2 - k * (v_ij[j] - PIS[j]) ** 2 - p
 
-        solutions = TOPSISAggregationFunction.solve_quadratic_equation(
+        solutions = TOPSISAggregationFunction.__solve_quadratic_equation(
             a, b, c
         )  # solutions are performance modifications in CS !!!
         if solutions is None:
@@ -1834,7 +1818,7 @@ def improvement_single_feature(
             solution_2 = solutions[1] + performances_CS[j]
 
         # solution -- new performances in CS
-        solution = TOPSISAggregationFunction.choose_appropriate_solution(
+        solution = TOPSISAggregationFunction.__choose_appropriate_solution(
             solution_1, solution_2, lower_bound, upper_bound, objective
         )
         if solution is None: