Skip to content

Commit

Permalink
Use fontawesome icon instead of external image
Browse files Browse the repository at this point in the history
edit-alt class is linked to an external image on Wok. There is no need
to use it as fontawesome has the same icon available.

Signed-off-by: Aline Manera <aline.manera@gmail.com>
  • Loading branch information
alinefm committed Sep 12, 2017
1 parent fa3a0e2 commit 44c71d9
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions ui/css/kimchi.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Project Kimchi
*
* Copyright IBM Corp, 2015-2017
* Copyright IBM Corp, 2015-2016
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -798,7 +798,7 @@
display: none;
}

#guest-content-container .wok-guest-gallery .wok-guest-list-item .guest-done {
#guest-content-container .wok-guest-gallery .wok-guest-list-item .guest-actions {
display: none;
}

Expand Down
2 changes: 1 addition & 1 deletion ui/css/src/modules/_guests.scss
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@
}
}
}
.guest-done {
.guest-actions {
display: none;
}
.guest-state {
Expand Down
2 changes: 1 addition & 1 deletion ui/js/src/kimchi.guest_main.js
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ kimchi.createGuestLi = function(vmObject, prevScreenImage, openMenu) {
});
} else {
guestActions.find('.btn').attr('disabled', true);
result.find('.guest-done').addClass('hidden');
result.find('.guest-actions').addClass('hidden');
result.find('.guest-state').addClass('hidden');
result.find('.guest-pending').removeClass('hidden');
pendingText = result.find('.guest-pending .text')
Expand Down
4 changes: 1 addition & 3 deletions ui/pages/guest.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@
<span class="pull-right">
<div class="dropdown menu-flat guest-actions" name="guest-actions">
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false">
<span class="guest-done">
<span class="edit-alt"></span>$_("Actions")<span class="caret"></span>
</span>
<i class="fa fa-pencil-square-o" aria-hidden="true"> </i>$_("Actions")<span class="caret"></span>
<span class="guest-state">
<span class="running"><i class="fa fa-power-off"></i><span class="text-status">$_("Running")</span></span><!--
--><span class="shutoff shutdown blocked"><i class="fa fa-ban"></i><span class="text-status">$_("Disconnected")</span></span><!--
Expand Down
3 changes: 2 additions & 1 deletion ui/pages/tabs/network.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@
--><span class='column-action' style="display:none">
<span class="pull-right">
<div class="dropdown menu-flat">
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false"><span class="edit-alt"></span>$_("Actions")<span class="caret"></span>
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false">
<i class="fa fa-pencil-square-o" aria-hidden="true"> </i>$_("Actions")<span class="caret"></span>
</button>
<ul class="dropdown-menu" role="menu">
<li role="presentation" nwAct="start" class='{startClass}'><a><i class="fa fa-undo"></i>$_("Start")</a></li>
Expand Down
8 changes: 6 additions & 2 deletions ui/pages/tabs/storage.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@
--><span class="column-action storage-button" style="display:none">
<span class="pull-right">
<div class="dropdown menu-flat storage-action" data-state="{state}" data-type="{type}" data-name="{name}">
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false" aria-haspopup="true"><span class="edit-alt"></span>$_("Actions")<span class="caret"></span></button>
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false" aria-haspopup="true">
<i class="fa fa-pencil-square-o" aria-hidden="true"> </i>$_("Actions")<span class="caret"></span>
</button>
<ul class="dropdown-menu actionsheet">
<li><a href="#" class="pool-deactivate" data-inuse="{in_use}" data-stat="{state}" data-name="{name}" data-persistent="{persistent}"><i class="fa fa-minus-circle"></i>$_("Deactivate")</a></li>
<li><a href="#" class="pool-activate" data-stat="{state}" data-name="{name}"><i class="fa fa-power-off"></i>$_("Activate")</a></li>
Expand All @@ -110,7 +112,9 @@
<div class="col-sm-7">
<div class="btn-group">
<div class="dropdown menu-flat pool-action">
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false" aria-haspopup="true"><span class="edit-alt"></span>$_("Actions")<span class="caret"></span></button>
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false" aria-haspopup="true">
<i class="fa fa-pencil-square-o" aria-hidden="true"> </i>$_("Actions")<span class="caret"></span>
</button>
<ul class="dropdown-menu actionsheet">
<li class="disabled"><a href="#" class="volume-add" data-stat="{state}" data-name="{name}" data-type="{type}"><i class="fa fa-plus-circle"></i> $_("Add Volume")</a></li>
<li class="disabled"><a href="#" class="volume-resize" data-name="{name}"><i class="fa fa-external-link-square"></i> $_("Resize")</a></li>
Expand Down
3 changes: 2 additions & 1 deletion ui/pages/tabs/templates.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@
--><span class='column-action pull-right'>
<span class="pull-right">
<div class="dropdown menu-flat">
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false"><span class="edit-alt"></span>$_("Actions")<span class="caret"></span>
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown" aria-expanded="false">
<i class="fa fa-pencil-square-o" aria-hidden="true"> </i>$_("Actions")<span class="caret"></span>
</button>
<ul class="dropdown-menu" role="menu">
<li nwAct="edit" class='template-edit'><a href="#" data-template='{name}'><i class="fa fa-pencil"></i>$_("Edit")</a></li>
Expand Down

0 comments on commit 44c71d9

Please sign in to comment.