Basketball add expected return date to player #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 82.71% 82.73% +0.01%
==========================================
Files 61 61
Lines 2326 2328 +2
==========================================
+ Hits 1924 1926 +2
Misses 402 402 ☔ View full report in Codecov by Sentry. |
cwendt94
reviewed
Feb 4, 2025
espn_api/basketball/player.py
Outdated
| @@ -18,6 +18,8 @@ def __init__(self, data, year, pro_team_schedule = None): | |||
| self.posRank = json_parsing(data, 'positionalRanking') | |||
| self.stats = {} | |||
| self.schedule = {} | |||
| expected_return_date = json_parsing(data, 'expectedReturnDate') | |||
| self.expectedReturnDate = datetime(*expected_return_date).date() if expected_return_date else None | |||
There was a problem hiding this comment.
We can set this var name to expected_return_date, to follow better python standard. It was my bad habit of following the API name vars in the beginning of creating this package.
There was a problem hiding this comment.
Changed, thanks for the review!
|
Just need to resolve conflict and I can merge it in! |
|
Resolved, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small commit to add expected return date (from injury) to the player class. It returns a datetime date.
Example:
league.player_info(name="Jalen Johnson").expectedReturnDate)
Return:
2025-01-30
Alternatively if you prefer to keep it simple we could do it in one line:
self.expectedReturnDate = json_parsing(data, 'expectedReturnDate')
And then the same code returns:
[2025, 1, 30]
Just thought it might be nice to return in datetime format but I'm good with it either way.