Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danger: Albumentations MotionBlur is shifting our images #37

Closed
iago-suarez opened this issue Nov 1, 2023 · 0 comments · Fixed by #38
Closed

Danger: Albumentations MotionBlur is shifting our images #37

iago-suarez opened this issue Nov 1, 2023 · 0 comments · Fixed by #38
Labels
bug Something isn't working

Comments

@iago-suarez
Copy link
Collaborator

I realized that for some images, Albumentations is damaging our GT homographies because when MotionBlur is applied in

The image is shifted without updating the GT homography. This is the default behaviour but can be easily fixed by allow_shifted=False which will create a motion blur kernel that does not move the image.
@iago-suarez iago-suarez added the bug Something isn't working label Nov 1, 2023
@iago-suarez iago-suarez changed the title Danger: Albumentations Motion Blur is shifting our images Danger: Albumentations MotionBlur is shifting our images Nov 1, 2023
iago-suarez added a commit to iago-suarez/glue-factory that referenced this issue Nov 1, 2023
@iago-suarez
Fixing cvg#37
0d93e4c
@iago-suarez iago-suarez mentioned this issue Nov 1, 2023
Merged
@iago-suarez iago-suarez linked a pull request Nov 1, 2023 that will close this issue
Fixing #37 allow_shifted=False in MotionBlur #38
Merged
iago-suarez added a commit that referenced this issue Feb 12, 2024
@iago-suarez @rpautrat
Fixing #37 allow_shifted=False in MotionBlur (#38)
dc01ec8 
* Fixing #37

* Black formatting

---------

Co-authored-by: Rémi Pautrat <32239569+rpautrat@users.noreply.github.com>
Co-authored-by: Rémi Pautrat <remi.pautrat@polytechnique.org>
tompritch30 pushed a commit to tompritch30/glue-factory that referenced this issue May 30, 2024
@iago-suarez @rpautrat
Fixing cvg#37 allow_shifted=False in MotionBlur (cvg#38)
5d72930 
* Fixing cvg#37

* Black formatting

---------

Co-authored-by: Rémi Pautrat <32239569+rpautrat@users.noreply.github.com>
Co-authored-by: Rémi Pautrat <remi.pautrat@polytechnique.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing #37 allow_shifted=False in MotionBlur iago-suarez/glue-factory
1 participant
@iago-suarez