Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: public release build workflows #384

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Feb 17, 2025

closes: MBL-881, MBL-928

Changes

  • Refactored build-sample-app.yml workflow to support both manual and automated builds
  • Added build-release-sample-apps workflow to enable manual builds of sample apps using the public SDK release from npm
  • Added build-test-sample-apps.yml workflow to ensure builds on PRs and pushes to main continue to function
  • Replaced dev:update.sh with install-sdk-deps.sh for a better experience and improved handling of local and npm SDK installations
  • Updated version_helper.rb to reflect the SDK version used for the build
  • Updated package.json files in sample apps to include new scripts
  • Updated sample apps README to document the new option for installing npm SDK version

@mrehan27 mrehan27 self-assigned this Feb 17, 2025
@mrehan27 mrehan27 requested a review from a team as a code owner February 17, 2025 06:34
Copy link

github-actions bot commented Feb 17, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: 384.2.0 (28996797)
  • APN: 384.2.0 (28996797)

@customerio customerio deleted a comment from github-actions bot Feb 17, 2025
@customerio customerio deleted a comment from github-actions bot Feb 17, 2025
@mrehan27 mrehan27 force-pushed the rehan/mbl-881-public-release branch from 936cceb to 5fd44ad Compare February 17, 2025 09:18
@mrehan27 mrehan27 force-pushed the rehan/mbl-881-public-release branch from 9bc3b11 to 89cd342 Compare February 17, 2025 14:23
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +33 to +42
#### Using a Specific SDK Version with NPM

To install a specific SDK version in the sample app, run:

```bash
npm install --cio-rn-sdk=<SDK_VERSION>
```

If no version is provided, the SDK will default to the local dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@mrehan27 mrehan27 merged commit 529522a into main Feb 18, 2025
11 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-881-public-release branch February 18, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants