Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not bundle .md files in cocoapods deployments #246

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Mar 18, 2024

Fixes: https://linear.app/customerio/issue/MBL-180/[bug]-resolve-md-file-causing-compilation-issues-for-ios-customers

Customers experience compilation errors in their iOS/RN/Flutter/Expo apps due to customer's apps trying to parse .md files that are bundled with our SDK in production releases.

The issue is resolved by an update to the native iOS SDK cocoapods files. This change points to the latest cocoapods release to use these changes.

commit-id:a6f2ba6a

@levibostian levibostian requested a review from a team March 18, 2024 16:51
@levibostian
Copy link
Contributor Author

Failed CI status checks being fixed in another PR pointing to main

@levibostian
Copy link
Contributor Author

levibostian commented Mar 18, 2024

Do not merge until iOS 2.12.5 is successfully deployed to cocoapods.

Update: iOS has been deployed.

Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ran sample apps to verify the changes, might be good to update their Podfile.lock as well in this PR?

Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what Rehan said

Fixes: https://linear.app/customerio/issue/MBL-180/[bug]-resolve-md-file-causing-compilation-issues-for-ios-customers

Customers experience compilation errors in their iOS/RN/Flutter/Expo apps due to customer's apps trying to parse .md files that are bundled with our SDK in production releases.

The issue is resolved by an update to the native iOS SDK cocoapods files. This change points to the latest cocoapods release to use these changes.

commit-id:a6f2ba6a
@levibostian levibostian merged commit a815336 into main Mar 19, 2024
3 of 5 checks passed
@levibostian levibostian deleted the spr/main/a6f2ba6a branch March 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants