Add CI #144
Merged
Add CI #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, so I've rewritten the tests (and removed the unnecessarily huge test files) |
|
(Let me know if you are happy to merge) |
|
I'm happy to merge |
|
Let's do it! |
|
By the way @HKalbasi, would you be up for me adding your name to the README? (under the Acknowledgements section) |
|
It would be nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CI which checks tests, format and compiler errors and warnings. I ignored the failing test for now since you said you want to rewrite them. I also commit the Cargo.lock file, it would guarantee that ox build successfully if someone clone it (without Cargo.lock dependencies can accidentally create problems).