Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created AddClassModal + Created assignments, invoices, rooms endpoints #46

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Created AddClassModal + Created assignments, invoices, rooms endpoints #46

merged 3 commits into from
Jan 27, 2025

Conversation

brelieu05
Copy link
Contributor

Created AddClassModal + Created assignments, invoices, rooms endpoints

Description

Also changed bookings endpoint to remove extra variable in SQL query,

Screenshots/Media

image

Issues

Closes #39

@brelieu05
Removed extra variable from SQL query in bookings, Created AddClassMo…
d541c9e 
…dal.jsx, Created assignments, invoices, rooms routes
@theNatePi
Copy link
Collaborator

theNatePi commented Jan 22, 2025 •
edited by brelieu05
Loading

Great work @lanaramadan @brelieu05, just a small fix:

  • For DELETE /invoices/:id, make sure to return "error" if the invoice does not exist. Instead of using !data you should use data.length === 0
  • If you have time, take a look at your files to remove any unused imports

Really good work on the modal guys!!

theNatePi
theNatePi requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@theNatePi theNatePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes

brelieu05
brelieu05 commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@brelieu05 brelieu05 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, but i did add change the !data to data.length === 0, i just forgot to put it in the commit message

@brelieu05 brelieu05 requested a review from theNatePi January 23, 2025 06:24
@theNatePi
Copy link
Collaborator

LOL, is it working now 😭

@theNatePi
Copy link
Collaborator

Looks good to me!

@theNatePi theNatePi merged commit 3c7a082 into main Jan 27, 2025
1 check passed
@theNatePi theNatePi deleted the 39-create-endpoints-11-add-class-booking-modal-2 branch January 27, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessieh9 jessieh9 Awaiting requested review from jessieh9

@theNatePi theNatePi Awaiting requested review from theNatePi

Assignees

@lanaramadan lanaramadan

@brelieu05 brelieu05

Labels
Looks Good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Endpoints 11 - Add Class Booking Modal
3 participants
@brelieu05 @theNatePi @lanaramadan