added business requests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshualipton
reviewed
Dec 6, 2023
.pnp.cjs
Outdated
There was a problem hiding this comment.
We should not be adding these files to the commits
.pnp.loader.mjs
Outdated
There was a problem hiding this comment.
Same with this file, we don't want to add this
.yarn/install-state.gz
Outdated
routes/businessRouter.js
Outdated
| @@ -34,4 +34,239 @@ businessRouter.get('/:id', async (req, res) => { | |||
| } | |||
| }); | |||
|
|
|||
| // POST add a new business | |||
| businessRouter.post('/', async (req, res) => { | |||
| console.log(req.body); | |||
There was a problem hiding this comment.
Nit: We shouldn't have console logs in our final commits
routes/businessRouter.js
Outdated
| createdDate, | ||
| city, | ||
| } = req.body; | ||
| console.log(req.body); |
There was a problem hiding this comment.
Console log same as before
routes/businessRouter.js
Outdated
| ); | ||
| res.status(200).send(newBusiness); | ||
| } catch (err) { | ||
| res.status(400).send(err.message); |
There was a problem hiding this comment.
This should send a 500 error not a 400 error
routes/businessRouter.js
Outdated
| // Sending a response | ||
| response.status(200).send('Update successful'); | ||
| } catch (err) { | ||
| response.status(400).send(err.message); |
There was a problem hiding this comment.
This should be a 500 error
Madhu2244
reviewed
Dec 6, 2023
routes/businessRouter.js
Outdated
|
|
||
| const newBusiness = await db.query( | ||
| `INSERT INTO business ( | ||
| id, type, name, street, zipCode, state, qb_vendor_name, qb_city_state_zip, |
There was a problem hiding this comment.
Remove the id, we figured out how to auto increment it.
Madhu2244
reviewed
Dec 6, 2023
routes/businessRouter.js
Outdated
| VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, | ||
| $17, $18, $19, $20, $21, $22, $23, $24, $25, $26, $27, $28, $29, $30, | ||
| $31, $32, $33, $34, $35, $36, $37, $38, $39, $40, $41, $42, $43, $44, | ||
| $45, $46, $47, $48, $49, $50, $51, $52, $53, $54, $55) |
There was a problem hiding this comment.
Just remember to remove $55 when you are removing the id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.