Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up market values get and post #15

Merged
merged 3 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/scripts/reviewReviewed.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ const messageAssignee = async ({ context }) => {
try {
const UserModel = getUserModel();
const slackAssignees = await Promise.allSettled(
githubAssignees.map(assignee => UserModel.findOne({ github: assignee.login })),
githubAssignees.map((assignee) => UserModel.findOne({ github: assignee.login })),
);
if (context.payload.review.state === 'approved') {
await Promise.all(
slackAssignees.map(assignee =>
slackAssignees.map((assignee) =>
Bot.client.chat.postMessage({
channel: assignee.value?.slackId,
text: `One of your pull requests has been APPROVED by ${reviewer}! <${url}|View Review> :shrek::thumbsup:`,
Expand All @@ -53,7 +53,7 @@ const messageAssignee = async ({ context }) => {
);
} else {
await Promise.all(
slackAssignees.map(assignee =>
slackAssignees.map((assignee) =>
Bot.client.chat.postMessage({
channel: assignee.value?.slackId,
text: `One of your pull requests has been REVIEWED by ${reviewer}! <${url}|View Review> :shrek:`,
Expand Down
4 changes: 2 additions & 2 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require('dotenv').config();
const businessRouter = require('./routes/businessRouter');
// const donationRouter = require('./routes/donationRouter');
// const notificationRouter = require('./routes/notificationRouter');
// const valueRouter = require('./routes/valueRouter');
const valueRouter = require('./routes/valueRouter');

const app = express();
app.use(express.json());
Expand All @@ -23,7 +23,7 @@ app.use(
app.use('/business', businessRouter);
// app.use('/donation', donationRouter);
// app.use('/notification', notificationRouter);
// app.use('/value', valueRouter);
app.use('/value', valueRouter);

app.listen(PORT, () => {
console.log(`Server listening on ${PORT}`);
Expand Down
45 changes: 41 additions & 4 deletions routes/valueRouter.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,43 @@
// const express = require('express');
// const { db } = require('../server/db');
const express = require('express');
const { db } = require('../server/db');

// Your code below (delete this line when committing):
const valueRouter = express.Router();

// const valueRouter = express.Router();
// GET all items
valueRouter.get('/', async (req, res) => {
try {
const allItems = await db.query(`SELECT * FROM fair_market_value;`);
res.status(200).send(allItems);
} catch (err) {
res.status(500).send(err.message);
}
});

// GET all values by item id
valueRouter.get('/:itemId', async (req, res) => {
try {
const { itemId } = req.params;
const item = await db.query('SELECT * FROM fair_market_value WHERE item_id = $(itemId)', {
itemId,
});
res.status(200).send(item);
} catch (err) {
res.status(500).send(err.message);
}
});

// CREATE a new item
valueRouter.post('/', async (req, res) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async arrow function.

try {
const { itemName, quantityType, quantity, price } = req.body;
const newItem = await db.query(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'newItem' is assigned a value but never used.

'INSERT INTO fair_market_value (item_name, quantity_type, quantity, price) VALUES ($(itemName), $(quantityType), $(quantity), $(price)) RETURNING *',
{ itemName, quantityType, quantity, price },
);
return res.status(200).send(newItem);
} catch (err) {
return res.status(500).send(err.message);
}
});

module.exports = valueRouter;