Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release v2.1.0a #128

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Pre-release v2.1.0a #128

merged 1 commit into from
Aug 30, 2024

Conversation

csyhuang
Copy link
Owner

This pre-release is made for the sake of generating a zenodo code to be included in Lubis et al. (in prep). Functionality to compute the contribution of diabatic heating in the wave activity budget equation is included. See documentation of QGField.compute_lwa_and_barotropic_fluxes for details. A formal release will be made once the manuscript is finalized.

@chpolste I'm tagging you as reviewer to inform you of the changes, but you don't have to review at the moment. The non-conservative force calculation is not made available in QGDataset yet - I will modify QGDataset accordingly and request your review for the PR of formal release v2.1.0 once the manuscript in prep is finalized. Thanks!

@csyhuang csyhuang requested a review from chpolste August 30, 2024 21:31
@csyhuang csyhuang self-assigned this Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.20%. Comparing base (57d5f45) to head (5bfee5b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/falwa/oopinterface.py 63.15% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   57.09%   57.20%   +0.11%     
==========================================
  Files          11       11              
  Lines        1487     1505      +18     
==========================================
+ Hits          849      861      +12     
- Misses        638      644       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csyhuang csyhuang merged commit 640960e into master Aug 30, 2024
3 checks passed
@csyhuang csyhuang deleted the pr_branch_v2.1.0a branch August 31, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants