Ensure stable order of ‘Set-ItemProperty’ calls for desktop icons

cschneegans · Jan 30, 2025 · c84a423 · c84a423
1 parent 1309501
commit c84a423
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/Main.cs b/Main.cs
@@ -695,13 +695,18 @@ public class DesktopIcon(
   string id,
   string displayName,
   string guid
-) : IKeyed
+) : IKeyed, IComparable<DesktopIcon>
 {
   public string Id { get; } = id;
 
   public string DisplayName { get; } = displayName;
 
   public string Guid { get; } = guid;
+
+  public int CompareTo(DesktopIcon? other)
+  {
+    return Id.CompareTo(other?.Id);
+  }
 }
 
 public class TimeOffset(

diff --git a/modifier/Optimizations.cs b/modifier/Optimizations.cs
@@ -1,5 +1,6 @@
 using Newtonsoft.Json;
 using System;
+using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.IO;
 using System.Text;
@@ -112,9 +113,15 @@ public interface IDesktopIconSettings;
 
 public record class DefaultDesktopIconSettings : IDesktopIconSettings;
 
-public record class CustomDesktopIconSettings(
-  ImmutableDictionary<DesktopIcon, bool> Settings
-) : IDesktopIconSettings;
+public record class CustomDesktopIconSettings : IDesktopIconSettings
+{
+  public CustomDesktopIconSettings(IDictionary<DesktopIcon, bool> settings)
+  {
+    Settings = ImmutableSortedDictionary.CreateRange(settings);
+  }
+
+  public ImmutableSortedDictionary<DesktopIcon, bool> Settings { get; init; }
+}
 
 class OptimizationsModifier(ModifierContext context) : Modifier(context)
 {