Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decomposedfs): available space calculation #4867

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Sep 25, 2024

Move the calculation of the available size to the blobstore interface. We were just returning the available size of the local disk, which is wrong when using the S3 blobstore.

Also, as the S3 blobstore doesn't have a concept of available size, we don't return a 'remaining' for S3 backed spaces with unlimited quota.

Fixes: owncloud/ocis#9245

@rhafer rhafer marked this pull request as ready for review September 25, 2024 08:28
@rhafer rhafer requested review from a team, labkode and glpatcern as code owners September 25, 2024 08:28
@rhafer rhafer self-assigned this Sep 25, 2024
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual nitpicking 👍

Move the calculation of the available size to the blobstore interface.
We were just returning the available size of the local disk, which is
wrong when using the S3 blobstore.

Also, as the S3 blobstore doesn't have a concept of available size, we
don't return a 'remaining' for S3 backed spaces with unlimited quota.

Fixes: owncloud/ocis#9245
@rhafer rhafer merged commit b5c3c67 into cs3org:edge Sep 26, 2024
9 checks passed
rhafer added a commit to rhafer/ocis that referenced this pull request Sep 26, 2024
rhafer added a commit to owncloud/ocis that referenced this pull request Sep 26, 2024
ownclouders pushed a commit to owncloud/ocis that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants