remove hardcoded placeholder signing key

Author: jessegeens

internal/http/services/owncloud/ocdav/trashbin.go

@@ -77,11 +77,6 @@ func (h *TrashbinHandler) handleTrashbinSpaces(s *svc, w http.ResponseWriter, r
 	key, r.URL.Path = router.ShiftPath(r.URL.Path)
 	if key != "" && r.Method == MethodMove {
 		// find path in url relative to trash base
-		// trashBase := ctx.Value(ctxKeyBaseURI).(string)
-		// baseURI := path.Join(path.Dir(trashBase), "files", username)
-		// ctx = context.WithValue(ctx, ctxKeyBaseURI, baseURI)
-		// r = r.WithContext(ctx)
-
 		// TODO make request.php optional in destination header
 		dst, err := extractDestination(r)
 		if err != nil {

internal/http/services/owncloud/ocs/config/config.go

@@ -47,6 +47,7 @@ type Config struct {
 	ListOCMShares            bool                              `mapstructure:"list_ocm_shares"`
 	Notifications            map[string]interface{}            `mapstructure:"notifications"`
 	EnableSpaces             bool                              `mapstructure:"enable_spaces"`
+	SigningKey               string                            `mapstructure:"signing_key"`
 }
 
 // Init sets sane defaults.

internal/http/services/owncloud/ocs/handlers/cloud/user/user.go

@@ -39,15 +39,21 @@ import (
 type Handler struct {
 	gatewayAddr      string
 	allowedLanguages []string
+	signingKey       string
 }
 
 // Init initializes this and any contained handlers.
-func (h *Handler) Init(c *config.Config) {
+func (h *Handler) Init(c *config.Config) error {
+	if len(c.SigningKey) < 32 {
+		return errors.New("Please set a signing key with an appropriate length")
+	}
 	h.gatewayAddr = c.GatewaySvc
 	h.allowedLanguages = c.AllowedLanguages
+	h.signingKey = c.SigningKey
 	if len(h.allowedLanguages) == 0 {
 		h.allowedLanguages = []string{"cs", "de", "en", "es", "fr", "it", "gl"}
 	}
+	return nil
 }
 
 const (
@@ -85,7 +91,7 @@ func (h *Handler) SigningKey(w http.ResponseWriter, r *http.Request) {
 
 	response.WriteOCSSuccess(w, r, &SigningKey{
 		User:       u.Username,
-		SigningKey: "UGFyY2UgbWVybywgY29lbmF0byBwYXJ1bTogbm9uIHNpdCB0aWJpIHZhbnVtClN1cmdlcmUgcG9zdCBlcHVsYXM6IHNvbW51bSBmdWdlIG1lcmlkaWFudW06Ck5vbiBtaWN0dW0gcmV0aW5lLCBuZWMgY29tcHJpbWUgZm9ydGl0ZXIgYW51bS4KSGFlYyBiZW5lIHNpIHNlcnZlcywgdHUgbG9uZ28gdGVtcG9yZSB2aXZlcw==",
+		SigningKey: h.signingKey,
 	})
 }