Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmarks to use libcrux_ecdh API #821

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update benchmarks to use libcrux_ecdh API #821

merged 2 commits into from
Feb 12, 2025

Conversation

wysiwys
Copy link
Contributor

@wysiwys wysiwys commented Feb 12, 2025

This PR replaces the libcrux::ecdh API calls in the benchmarks with calls to the libcrux_ecdh (top-level crate) API.

Resolves #763

@wysiwys wysiwys requested a review from a team as a code owner February 12, 2025 15:15
@wysiwys wysiwys self-assigned this Feb 12, 2025
keks
keks approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@keks keks merged commit 742939d into main Feb 12, 2025
65 checks passed
@keks keks deleted the wysiwys/update-ecdh-benches branch February 12, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keks keks keks approved these changes

Assignees

@wysiwys wysiwys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECDH benchmarks
2 participants
@wysiwys @keks