-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ScreenManager to no longer reuse screen instances. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closer resemblence with libGDX's Game class. Some of the changes introduced were: - Screens & transitions don't have to be registered anymore - ScreenManager#push now takes a ManagedScreen and a ScreenTransition as arguments - ManagedGame#initialize & ManagedGame#create were removed which should remove the confusion around the difference between constructors, #create() and #show() - ScreenTransition#reset was removed in favour of ScreenTransition#show and #hide - ShaderTransitions now compile the shader in the constructor - There were extensive improvements to the javadocs to better document when each method is called
it easier to extend the class.
ScreenManager & move #screenToTexture into its own utility class.
and #transitionQueue to child classes.
4 tasks
…reenmanager.git into create_new_instances
git@github.com:crykn/libgdx-screenmanager.git into create_new_instances
crykn
added a commit
that referenced
this pull request
Jan 15, 2024
This was accidentally removed in #26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ScreenManager to no longer reuse screen instances. This leads to closer resemblence with libGDX's
Game
class.To test these changes, use version
c9a1f42d83
for screenmanager and versionv0.3.5
for guacamole. The GWT extension was removed, so the GWT dependencies should now look like this:The module file needs to include the following entry:
Changes
ScreenManager#push
now takes aManagedScreen
and aScreenTransition
instance as argumentsManagedGame#initialize
&ManagedGame#create
were removed which should eliminate the confusion around the difference between constructors,#create()
and#show()
; old code should be put in the constructor or#show()
ScreenTransition#reset
was removed in favour ofScreenTransition#show
and#hide
; old code should be put in#show()
ShaderTransition
s now compile the shader in the constructor; this means that the constructor has to be called on the OpenGL threadScreenManager#setAutoDispose(true, true)
if you don't want to reuse your screens and transitions and thus they should be disposed automatically upon#hide()
ToDo
sourceSet
, so they can actually be run when the project is imported into an IDE