Fix bug - update groupInfo as well when there're no valid members

crustio · Jun 21, 2024 · 2a9ac15 · 2a9ac15
1 parent 966254f
commit 2a9ac15
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/src/tasks/group-info-updater-task.ts b/src/tasks/group-info-updater-task.ts
@@ -55,16 +55,17 @@ async function handleUpdate(context: AppContext, logger: Logger) {
 
     if (validMembers.length > 0) {
       logger.info(`load ${validMembers.length} valid group members`);
-      validMembers.sort();
-      const nodeIndex = validMembers.indexOf(api.getChainAccount());
-      context.groupInfo = {
-        groupAccount: groupOwner,
-        totalMembers: validMembers.length,
-        nodeIndex,
-      };
     } else {
       logger.warn(`load ${validMembers.length} valid group members`);
     }
+
+    validMembers.sort();
+    const nodeIndex = validMembers.indexOf(api.getChainAccount());
+    context.groupInfo = {
+      groupAccount: groupOwner,
+      totalMembers: validMembers.length,
+      nodeIndex,
+    };
   } catch (e) {
     logger.error('failed updating group info: %s', formatError(e));
     context.groupInfo = null;

diff --git a/src/tasks/pull-utils.ts b/src/tasks/pull-utils.ts
@@ -55,10 +55,7 @@ export async function filterFile(
   const groupInfo = context.groupInfo;
   try {
     const bn = cidToBigNumber(record.cid);
-    if (
-      groupInfo.totalMembers > 0 &&
-      !bn.mod(groupInfo.totalMembers).eq(groupInfo.nodeIndex)
-    ) {
+    if (groupInfo.totalMembers == 0 || !bn.mod(groupInfo.totalMembers).eq(groupInfo.nodeIndex) ) {
       return 'nodeSkipped';
     }
   } catch (ex) {