[WIP] Ship details #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I just added the travel data. My time is limited so please go ahead and make the needed changes in your PR, then I'll merge and deploy. Thanks. |
|
No problem, my time is also limited. I want to finish the ship detail page as well. The goal is to have a select box with all compatible engines. Maybe the main weapons, turrets and shields will be also included in this PR. Depending how complicated it will be to serve a dynamic amount of select boxes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to expand the table with additional ship data.
Speed, Acceleration and Cargo are the new columns. For travel speed I would need additional data from within the game data.
Additionally I've added a persistance to the data table. So if someone set some filter, they will be stored in the LocalStorage. Also a "Column Chooser" is available to filter out the visible columns.
The speed and acceleration is taken from the best available engine. I've added a footer with the info.
I've only picked some ships for testing and compared them with the ingme encyclopedia.
If you could provide the additional data, I will expand the table.