fix: do not call deleteUserAddress for unlogged users (SAP#19649)

CXSPA-8873
crisli001 · Dec 2, 2024 · 20683ab · 20683ab
1 parent ca5e89d
commit 20683ab
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 7 deletions.
diff --git a/integration-libs/opf/quick-buy/core/services/opf-quick-buy-transaction.service.spec.ts b/integration-libs/opf/quick-buy/core/services/opf-quick-buy-transaction.service.spec.ts
@@ -427,9 +427,11 @@ describe('OpfQuickBuyTransactionService', () => {
   });
 
   describe('deleteUserAddresses', () => {
-    it('should call deleteUserAddress for each address ID', () => {
+    it('should call `deleteUserAddress` for each address ID for logged in users', () => {
       const addrIds = ['addr1', 'addr2', 'addr3'];
 
+      authService.isUserLoggedIn.and.returnValue(of(true));
+
       service.deleteUserAddresses(addrIds);
 
       addrIds.forEach((addrId) => {
@@ -439,9 +441,21 @@ describe('OpfQuickBuyTransactionService', () => {
       });
     });
 
+    it('should not call `deleteUserAddress` for unauthenticated users', () => {
+      const addrIds = ['addr1', 'addr2', 'addr3'];
+
+      authService.isUserLoggedIn.and.returnValue(of(false));
+
+      service.deleteUserAddresses(addrIds);
+
+      expect(userAddressService.deleteUserAddress).toHaveBeenCalledTimes(0);
+    });
+
     it('should disable global messages for address deletion success', () => {
       const addrIds = ['addr1', 'addr2'];
 
+      authService.isUserLoggedIn.and.returnValue(of(true));
+
       service.deleteUserAddresses(addrIds);
 
       expect(opfGlobalMessageService.disableGlobalMessage).toHaveBeenCalledWith(

diff --git a/integration-libs/opf/quick-buy/core/services/opf-quick-buy-transaction.service.ts b/integration-libs/opf/quick-buy/core/services/opf-quick-buy-transaction.service.ts
@@ -176,12 +176,19 @@ export class OpfQuickBuyTransactionService {
   }
 
   deleteUserAddresses(addrIds: string[]): void {
-    this.opfGlobalMessageService.disableGlobalMessage([
-      'addressForm.userAddressDeleteSuccess',
-    ]);
-    addrIds.forEach((addrId) => {
-      this.userAddressService.deleteUserAddress(addrId);
-    });
+    this.authService
+      .isUserLoggedIn()
+      .pipe(take(1))
+      .subscribe((isUserLoggedIn) => {
+        if (isUserLoggedIn) {
+          this.opfGlobalMessageService.disableGlobalMessage([
+            'addressForm.userAddressDeleteSuccess',
+          ]);
+          addrIds.forEach((addrId) => {
+            this.userAddressService.deleteUserAddress(addrId);
+          });
+        }
+      });
   }
 
   createCartGuestUser(): Observable<boolean> {