Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Academic Course query. #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Academic Course query. #91

wants to merge 1 commit into from

Conversation

BigBlueHat
Copy link
Contributor

@BigBlueHat BigBlueHat commented Jan 7, 2025

The credential was refactored some time ago to remove the inline context. This updates the query to match those earlier changes.

This needs some more testing... Recent tests on the Playground (using Custom Query) were not working for me. However, this query looks correct...so hoping another set of eyes on the problem might help.

Thanks!
🎩

Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying vc-examples with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7adf6ad
Status: ✅  Deploy successful!
Preview URL: https://5952678d.vc-examples.pages.dev
Branch Preview URL: https://fix-alumni-query.vc-examples.pages.dev

View logs

The credential was refactored some time ago to remove the inline
context. This updates the query to match those earlier changes.
@jameseaster
Copy link
Contributor

jameseaster commented Jan 15, 2025

@BigBlueHat This one is stumping me... I don't see anything overtly wrong with the query.

My steps (repeated many times with slight variation, altering the @context array):

  • Symlinked the vc-examples to my local playground
  • Issued the academic course credential
  • Then attempted to verify it and the playground can't find it

@davidlehn @dlongley Any thoughts here, something we're missing?

@dlongley
Copy link
Contributor

dlongley commented Feb 5, 2025

@jameseaster,

Then attempted to verify it and the playground can't find it

Does this mean a wallet can't find it? If not, what exactly does it mean for the playground to not find it -- does that mean somewhere in the query infrastructure stuff?

Or is this no longer a problem and this PR is ready to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants