Skip to content

Merge: Dev to Qa (25/04/2024) #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 25, 2025
Merged

Merge: Dev to Qa (25/04/2024) #1195

merged 19 commits into from
Apr 25, 2025

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Merge changes from DEV to QA.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2025
View reviewed changes
apps/api-gateway/src/issuance/issuance.controller.ts
.status(error.statusCode || HttpStatus.INTERNAL_SERVER_ERROR)
.header('Content-Type', 'application/json')
.header('Content-Disposition', '')
.send(error);

Check warning

Code scanning / CodeQL

Information exposure through a stack trace Medium

This information exposed to the user depends on
stack trace information
Loading
.

Copilot Autofix

AI 15 days ago

To fix the issue, we need to ensure that sensitive information, such as stack traces or internal error details, is not exposed to the client. Instead, we should log the full error details on the server for debugging purposes and send a generic error message to the client. This can be achieved by:

  1. Logging the full error details (including the stack trace) using a logging mechanism such as Logger.error.
  2. Sending a generic error message to the client, such as "An internal server error occurred."

The changes will be made in the catch block of the downloadBulkIssuanceCSVTemplate method, specifically replacing the res.send(error) call with logging and a generic response.

Suggested changeset 1
apps/api-gateway/src/issuance/issuance.controller.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/api-gateway/src/issuance/issuance.controller.ts b/apps/api-gateway/src/issuance/issuance.controller.ts
--- a/apps/api-gateway/src/issuance/issuance.controller.ts
+++ b/apps/api-gateway/src/issuance/issuance.controller.ts
@@ -292,2 +292,3 @@
     } catch (error) {
+      Logger.error('Error occurred in downloadBulkIssuanceCSVTemplate', error.stack || error.message);
       return res
@@ -296,3 +297,3 @@
         .header('Content-Disposition', '')
-        .send(error);
+        .send({ message: 'An internal server error occurred' });
     }
EOF
@@ -292,2 +292,3 @@
} catch (error) {
Logger.error('Error occurred in downloadBulkIssuanceCSVTemplate', error.stack || error.message);
return res
@@ -296,3 +297,3 @@
.header('Content-Disposition', '')
.send(error);
.send({ message: 'An internal server error occurred' });
}
Copilot is powered by AI and may make mistakes. Always verify output.
Copy link
Contributor

@GHkrishna GHkrishna Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavanakarwade have a look at this, as we don't want to give the completed stack trace to user as an error message.

So instead of sending error we can log the error and send something went wrong. It's okay if we don't undertake it in this PR. Maybe we can create an issue for this.

@bhavanakarwade bhavanakarwade self-assigned this Apr 25, 2025
sairanjit and others added 18 commits April 25, 2025 13:08
@sairanjit @KambleSahil3
chore: remove yarn.lock and package-lock.json files (#1133)
3ed7f08 
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
fix: platform agent set up issue (#1136)
4cc4990 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
fix: Parameter validations (#1138)
cad2ce0 
* fix: added api param validations

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: removed unnecessary validations

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix:resolved validations issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* added comment on function for understanding

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolve orgid validations

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added response message

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added space in response messages

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@pallavighule @KambleSahil3
added tenant id in get org info (#1139)
cd511c5 
Signed-off-by: pallavighule <pallavi.ghule@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3
fix/added-yml-file-to-push-docker-images (#1142)
ce43162 
* fix: removed prisma commands in build stage

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* feat: create yml file for all services

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* Updated Dockerfiles

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* Updated yml to push docker images

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* updated yml files

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

---------

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3
fix/push docker image (#1154)
57fe9b6 
* fix: used single yml file using matrix instead of multiple files

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* fix: renamed yml file to cicd.yml

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

* chore: removed id-token and attestations

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>

---------

Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sairanjit @tipusinghaw @KambleSahil3
chore: add aws module into monorepo (#1135)
fb74164 
* chore: add aws into monorepo

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* chore: update tsconfig

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor:tsconfig.build.json file

Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>

* refactor: remove redundant .nvmrc file

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

---------

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
Co-authored-by: Tipu_Singh <tipu.singh@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sairanjit @KambleSahil3
chore: remove unused modules (#1163)
5448b6d 
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sairanjit @KambleSahil3
refactor: remove image-service from libs (#1164)
4ceb01b 
Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sairanjit @KambleSahil3
refactor: merge nats-interceptor and responses lib into common (#1165)
773276f 
* refactor: merge nats-interceptor into common

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: merge repsonses lib into common

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: create common function to handle errors

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* chore: add todo

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* fix: remove missed image service

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* fix: create separate function to handle common error

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* chore: add comment for the purpose of the functions

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* chore: update function comments

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

---------

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sairanjit @KambleSahil3
refactor: create common package in libs (#1167)
684ab5a 
* refactor: merge nats-interceptor into common

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: merge repsonses lib into common

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: create common function to handle errors

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* chore: add todo

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: create common package in libs

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* fix: remove missed image service

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

* refactor: common service

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>

---------

Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
feat: Support nested attributes while creating schema (#1166)
5510042 
* wip: support nested attributes while creating schema

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* wip: aligned issuance functionality with nested attributes structure

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify csv to json function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: formatting changes

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved sonar cloud issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: security hotspot issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added schema builder function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify extract attributes function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: destructured objects

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added description property

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
refactor: schema data type validations (#1174)
a1c38ea 
* wip: support nested attributes while creating schema

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* wip: aligned issuance functionality with nested attributes structure

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify csv to json function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: formatting changes

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved sonar cloud issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: security hotspot issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added schema builder function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify extract attributes function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: destructured objects

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added description property

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added validations for schema type

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* formatted enum file

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* chore: added enum for indy schema data type

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@pranalidhanavade @KambleSahil3
refactor: update organization API to support updation of country, sta…
112c046 
…te and city (#1180)

* refactor: update organization API to support updation of country, state and city

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* resolved sonarlint issues

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* resolved sonarlint issues

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
refactor: error handling for download csv file (#1182)
13565c8 
* wip: support nested attributes while creating schema

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* wip: aligned issuance functionality with nested attributes structure

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify csv to json function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: formatting changes

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved sonar cloud issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: security hotspot issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added schema builder function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refactor: modify extract attributes function

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: destructured objects

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: added description property

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added validations for schema type

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* formatted enum file

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* chore: added enum for indy schema data type

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* chore: refactor validations

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
feat: implemented get verified presentation counts by issuer id (#1184)
fb5ebde 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@GHkrishna @KambleSahil3
fix: local setup issues (#1155)
b9d49b6 
* Update start_agent.sh

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

* Update .env.demo

fix: correct script for local build

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>

---------

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@bhavanakarwade @KambleSahil3
fix: issues related nested attributes in issuance process (#1194)
216b108 
* fix: issues related nested attributes in issuance process

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added statuscode

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: required field validation for request id field

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3 KambleSahil3 changed the base branch from qa to main April 25, 2025 07:50
@KambleSahil3 KambleSahil3 changed the base branch from main to qa April 25, 2025 07:50
@KambleSahil3
chore: update .env.demo file (#1198)
d1f0679 
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
54 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@bhavanakarwade bhavanakarwade merged commit 9cfb001 into qa Apr 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankita-p17 ankita-p17 ankita-p17 approved these changes

@shitrerohit shitrerohit shitrerohit approved these changes

@RinkalBhojani RinkalBhojani RinkalBhojani approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

@tipusinghaw tipusinghaw Awaiting requested review from tipusinghaw

Assignees

@bhavanakarwade bhavanakarwade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bhavanakarwade @ankita-p17 @shitrerohit @RinkalBhojani @GHkrishna @sairanjit @pallavighule @KambleSahil3 @pranalidhanavade