Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Shell detection on windows in order to use gopsutil #4588

Open
1 task
rohanKanojia opened this issue Jan 30, 2025 · 0 comments
Open
1 task

Refactor Shell detection on windows in order to use gopsutil #4588

rohanKanojia opened this issue Jan 30, 2025 · 0 comments
Labels
kind/task Workable task

Comments

@rohanKanojia
Copy link
Contributor

Component

CLI

Task description

Description

Related to #4572

Another potential follow-up is to use detectShellByCheckingProcessTree in detect() in shell_windows.go as both seem to have similar functionalities.

Originally posted by @cfergeau in #4572 (review)

Expected Behavior

shell windows detection is refactored to use gopustil (excluding WSL as this approach doesn't work there)

Acceptance Criteria

  • shell_windows uses gopsutil to detect shell type from parent process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Workable task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohanKanojia