Don't allow URLs in username #16633
Merged
Don't allow URLs in username #16633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybrad
approved these changes
Feb 5, 2025
timkelty
force-pushed
the
feature/disallow-url-as-username
branch
from
ab8444c to
22f7c04
Compare
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default email templates print
user.friendlyName, and many email clients (like Gmail) will detect something that looks like a URL and automatically make it into a link.Allowing a user with a username that looks like a URL could thus be seen as a potential phishing attack, as Craft will send an email that ends up looking like it has a direct link to a potentially malicious URL.