-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Health]: Improve support for RecordingMethod
on Health Connect and HKWasUserEntered
on iOS
#1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardram
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and it runs on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Google Health Connect and Apple HealthKit both provide ways to distinguish samples collected "automatically" and manually entered data by the user.
Problem
Previously, the Health package did not support writing this to this metadata field when writing data, and in many cases you could not query or filter by the type when reading data (especially on Android).
Breaking changes
RecordingMethod
enum, containing the 4 values that Health Connect defines.isManualEntry
fromHealthDataPoint
in favor ofrecordingMethod
, of which the value is an enumRecordingMethod
includeManualEntry
(previously a boolean) in favor ofrecordingMethodsToFilter
, which is a list ofRecordingMethod
. This change affects the following functions for querying:getHealthDataFromTypes
getHealthIntervalDataFromTypes
getHealthAggregateDataFromTypes
is unaffected.recordingMethod
to write to HealthKit and Health Connect stores, and when querying the data again it will be included in the metadata. The default value isRecordingMethod.automatic
. This change affects:writeHealthData
writeWorkoutData
writeMealData
writeBloodPressure
writeBloodOxygen
writeMenstruationFlow
Other improvements