Skip to content

Commit

Permalink
try to see what affect this has on the GPA issue
Browse files Browse the repository at this point in the history
  • Loading branch information
au5ton committed Feb 25, 2023
1 parent 57866b8 commit 5521b25
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions mock-database/src/_mockDatabase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ export async function whenUploadQueueAdded(record: GradeDistributionCSVRow) {
* - AVG of 0 (sus)
* - totalEnrolled of 0
*/
//(record.AVG_GPA !== null)
// TODO: use `GDR.safeToIncludeGPA(record)`
if (record.AVG_GPA !== null) {
if (GDR.safeToIncludeGPA(record) && record.AVG_GPA !== null) {
// include in GPA
GPA.include(courseData.GPA, record.AVG_GPA);

Expand Down Expand Up @@ -237,7 +238,7 @@ export async function whenUploadQueueAdded(record: GradeDistributionCSVRow) {
if (instructorExists) {
// check if record has missing AVG
// TODO: use `GDR.safeToIncludeGPA(record)`
if (record.AVG_GPA !== null) {
if (GDR.safeToIncludeGPA(record) && record.AVG_GPA !== null) {
// include in GPA
GPA.include(instructorData.GPA, record.AVG_GPA);

Expand Down

0 comments on commit 5521b25

Please sign in to comment.