Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Python script with bash script for libwasm version detection #8078

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

@VolodymyrBg VolodymyrBg commented Mar 1, 2025

Description

This PR replaces the Python script get-libwasm-version.py with a minimal bash script that performs the same functionality. The Python script was overkill for such a simple operation and required installing Python dependencies, which is unnecessary.
The bash script:

  1. Extracts the version of CosmWasm/wasmvm/v2 from the go.mod file
  2. Optionally gets the checksum of a specific library file for that version
    Has the same command-line interface as the Python script
    Additionally, this PR:
  • Updates all references to the Python script in workflow files and build scripts
  • Removes the Python dependencies installation step from workflows
  • Removes the python-install-deps target from Makefile
  • Removes the requirements.txt file
    This change simplifies the build process and reduces dependencies.

closes: #7885

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@VolodymyrBg
Copy link
Author

Important note!!
there is need to delete 2 files:
scripts/get-libwasm-version.py
requirements.txt
but I don't know how to do it
I tried but the files weren't deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace get-libwasm-version.py script
1 participant