Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Constant Error Acknowledgment #7924

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Feb 6, 2025

Description

closes: #7914


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Waiting on tests

@gjermundgaraba gjermundgaraba merged commit 95a78d8 into feat/ibc-eureka Feb 6, 2025
70 checks passed
@gjermundgaraba gjermundgaraba deleted the aditya/const-err-ack branch February 6, 2025 18:26
@AdityaSripal AdityaSripal restored the aditya/const-err-ack branch February 6, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants