Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused inputs from e2e-manual-simd.yaml #7904

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hungdinh82
Copy link
Contributor

@hungdinh82 hungdinh82 commented Feb 3, 2025

Description

closes: #7711


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Feb 4, 2025

I can't really test if this works, since the branch is not here. Have you tested this anywhere?

@hungdinh82
Copy link
Contributor Author

The way I did it was by removing the inputs from e2e-manual-simd.yaml that are not present in e2e-test-workflow-call.yml: relayer-tag, relayer-type, and chain-binary. Please wait a moment, I will now test it again on my repo's CI.

@hungdinh82
Copy link
Contributor Author

I have tested it on my repo's CI, and it has passed.
@gjermundgaraba

@gjermundgaraba
Copy link
Contributor

I have tested it on my repo's CI, and it has passed. @gjermundgaraba

Do you have a link to the CI run?

@hungdinh82
Copy link
Contributor Author

I have tested it on my repo's CI, and it has passed. @gjermundgaraba

Do you have a link to the CI run?

hey, this link. On branch fix-ci-check

@gjermundgaraba
Copy link
Contributor

I am not seeing any runs of the workflow in question?

@hungdinh82
Copy link
Contributor Author

I sent the wrong CI. Could you review it again?
Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual simd e2e workflow dispatch is broken
2 participants