refactor: simplify 02-client router funcs #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
chatton,
DimitrisJim,
srdtrk and
crodriguezvega
as code owners
DimitrisJim
reviewed
Jul 16, 2024
| } | ||
|
|
||
| // GetRoute returns the LightClientModule registered for the provided client type or false otherwise. | ||
| func (rtr *Router) GetRoute(clientType string) (exported.LightClientModule, bool) { |
There was a problem hiding this comment.
is there any benefit in keeping this around? Can only see it meaningfully being used in Route? Should be able to inline logic there from looks of it.
There was a problem hiding this comment.
The routes map is unexported so this is just a dumb accessor. But indeed, it's only really being used from Route, but I don't think its a big deal
crodriguezvega
approved these changes
Jul 16, 2024
|
DimitrisJim
approved these changes
Jul 17, 2024
colin-axner
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of the PR is to reduce the amount of string parsing and duplicate code. Mostly usage of
ParseClientIdentifierwhen accessing the 02-client light client module router.func Route() (LightClientModule, error)methodGetRouteon the 02-clientRouterto acceptclientTypeonly (aligns with has/add funcs)MustParseClientIdentifierfor usage in 02-client handlersref: #6760 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.