query handlers are ignoring accumulate flag

[beer-1]

Summary of Bug

Affected Query Handlers:

• 02-client grpc_query #1
• 02-client grpc_query #2
• 02-client grpc_query #3
• 04-channel grpc_query

These query handlers are not properly considering the accumulate flag, which leads to incorrect pagination results. Specifically:

When pagination.limit = 1 is set, the response includes 2 items instead of 1.
When pagination.count_total = true is enabled alongside pagination.limit = 1, the response incorrectly includes all items instead of limiting to just 1.

Expected Behaviour

Should return pagination.limit of items

Version

• main
• v9
• v8
• v7

Steps to Reproduce

Do query with pagination setting

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned
• Estimate provided

[charymalloju]

@beer-1 I would like to work on this issue.

[beer-1]

yea sure please feel free to take and make PR!

[gjermundgaraba]

Hi :) Normally the team would assign the issue, when we agree about the issue and solution, but it's all good. I'll assign @charymalloju to this and will drop a review in a moment.

I added a couple of things to the issue:

• There is one more place where this seems to be a potential issue, so I added a link to that for 04-channel grpc_query.go
• Looking through our current supported versions, this issue is likely a problem there too. I will add the backport tag to the connected PR which will open new PRs to those release branches (and hopefully there will be no conflicts 🤞)

[gjermundgaraba]

We've decided to wait with this as 0.52 is on hold