Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for overriding USER #188

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

theseion
Copy link
Contributor

Overrideing the USER only makes sense if it can be configured at build time, as that user needs to exist on the system. For containers, this functionality doesn't make much sense anyway.

Fixes #184

@theseion theseion requested a review from fzipi January 24, 2024 13:58
Overrideing the USER only makes sense if it can be configured at build
time, as that user needs to exist on the system. For containers, this
functionality doesn't make much sense anyway.

Fixes coreruleset#184
@theseion theseion force-pushed the drop-user-override-support branch from bbb550d to de08b3b Compare January 24, 2024 14:03
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@fzipi fzipi merged commit 1bf9061 into coreruleset:develop Jan 24, 2024
5 checks passed
@theseion theseion deleted the drop-user-override-support branch January 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER does not work.
2 participants