Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add troubleshoot on documentation and some lint minor refactors #3934

Merged

Conversation

marcalexiei
Copy link
Contributor

Description

Closes #3894.

I added a new section in the documentation with the step to troubleshoot error similar to the one described on #3894.

I also made two additional changes:

  • I changed the error message to be more simple IMHO.
  • I used RuleConfigSeverity enum to compute outcome warnings and errors.
    (The enum was already imported)

Motivation and Context

#3894

Usage examples

N/A

How Has This Been Tested?

yarn test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Oops, would you mind rebasing this? Thanks
Thanks for your time!

@escapedcat
Copy link
Member

Thanks! Will merge as soon as we know that v19 is doing ok

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat escapedcat merged commit 6dbb98a into conventional-changelog:master Mar 2, 2024
7 checks passed
@marcalexiei marcalexiei deleted the feature/troubleshoot branch March 5, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feat: how to mitigate errors when adding a new rule and not updating all relevant packages
2 participants