docs: warn about adding capabilities #25348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
Luap99
reviewed
Feb 18, 2025
| `CAP_MKNOD` and `CAP_SYS_MODULE` are particularly dangerous. | ||
|
|
||
| Before adding any capability, review its security implications and | ||
| ensure it is really necessary for the container’s functionality. |
There was a problem hiding this comment.
I guess it would be good to mention capabilities(7) and user_namespaces(7) as reference here, user_namespaces because I saw a few people confused why the caps they were adding don't work when running rootless, i.e. CAP_MKNOD and CAP_SYS_MODULE do not work in a user namesapce.
There was a problem hiding this comment.
what do you think of the new version?
giuseppe
force-pushed
the
warn-about-using-capabilities
branch
2 times, most recently
from
f0942c5 to
1f21eb3
Compare
|
/lgtm |
rhatdan
reviewed
Feb 18, 2025
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2345676 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
warn-about-using-capabilities
branch
from
1f21eb3 to
b43863a
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2345676
Does this PR introduce a user-facing change?