Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4.1-crio] CVE-2024-11218 Fix #25347

Conversation

TomSweeneyRedHat
Copy link
Member

This addresses the Buildah CVE-2024-11218 issue in the v4.4.1-crio branch.

Fixes: https://issues.redhat.com/browse/OCPBUGS-44536

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

This addresses the Buildah CVE-2024-11218 issue in the v4.4.1-crio
branch.

Fixes: https://issues.redhat.com/browse/OCPBUGS-44536

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Feb 17, 2025
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@nalind
Copy link
Member

nalind commented Feb 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@nalind
Copy link
Member

nalind commented Feb 17, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@nalind
Copy link
Member

nalind commented Feb 17, 2025

/override "Windows Cross"
/label bloat_approved

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@nalind: The label(s) /label bloat_approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/override "Windows Cross"
/label bloat_approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@nalind: Overrode contexts on behalf of nalind: Windows Cross

In response to this:

/override "Windows Cross"
/label bloat_approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mheon mheon added the bloat_approved Approve a PR in which binary file size grows by over 50k label Feb 17, 2025
@mheon
Copy link
Member

mheon commented Feb 17, 2025

Windows cross job can be removed, but I'm OK to merge without it passing.

@Luap99
Copy link
Member

Luap99 commented Feb 18, 2025

/override "Windows Cross"

You cannot overwrite any job result, that is not compatible with cirrus and github merge protection will still block it if you try to do it on "Total Success" AFAIK.

@Luap99 Luap99 merged commit 6b6388a into containers:v4.4.1-crio Feb 18, 2025
33 of 37 checks passed
@Luap99
Copy link
Member

Luap99 commented Feb 18, 2025

Manually merged, not CI should be turned of like done in 4.4.1-rhel, if this branch is still needed we should pick the same cirrus fix in this crio branch.

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/v4.4.1-crio-CVE-2024-11218 branch February 18, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants