test/buildah-bud: run in parallel #25343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 708fe0af in buildah the tests can run in parallel, let's enable it here to get the same speed up. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
As they run parallel now we can use some more cores and remove the long timeout, they must be faster than the 20min default now. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
openshift-ci
bot
added
release-note-none
approved
Buildah bats tests have been made (mostly) parallel-safe in the past few months. One test is flaking, but it's not a test that needs to be run under podman: that functionality is almost entirely buildah-manifest-push so it uses the buildah binary, and doesn't exercise anything under podman. Therefore: 1) run bud tests with -j$(nproc) on fastvm (was: standardvm) 2) desperate scramble to parallelize podman system service. May not be quite 100% perfect, but I think this is in good enough shape for someone to adopt and push through. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
@flouthoc PTAL |
|
LGTM here, but I'll wait for a merge from @flouthoc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up CI times